[#3601] feat(trino-connector): Support automatically loading catalog to Trino by Trino SQL command #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
reviewed
May 29, 2024
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private String generateDropCatalogCommand(String name) throws Exception { | ||
| return String.format("DROP CATALOG %s", name); |
There was a problem hiding this comment.
Does the catalog name needs double quote?
There was a problem hiding this comment.
I am trying to use double quotes around the catalog name. I've found some bugs and will be working on them.
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Outdated
Show resolved
Hide resolved
|
@yuqi1129 overall LGTM, except the retry code, do you want to take another look? |
yuqi1129
reviewed
May 29, 2024
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Outdated
Show resolved
Hide resolved
...onnector/src/main/java/com/datastrato/gravitino/trino/connector/catalog/CatalogRegister.java
Outdated
Show resolved
Hide resolved
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
…talog to Trino by Trino SQL command (apache#3602) ### What changes were proposed in this pull request? 1、Support automatically loading catalog to Trino by using CREATE CATALOG command 2、Support drop catalog 3、Support update catalog ### Why are the changes needed? Fix: apache#3601 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
May 30, 2024
…talog to Trino by Trino SQL command (apache#3602) 1、Support automatically loading catalog to Trino by using CREATE CATALOG command 2、Support drop catalog 3、Support update catalog Fix: apache#3601 NO NO
jerryshao
pushed a commit
that referenced
this pull request
May 31, 2024
jerryshao
pushed a commit
that referenced
this pull request
May 31, 2024
…to Trino by Trino SQL command (#3602) ### What changes were proposed in this pull request? 1、Support automatically loading catalog to Trino by using CREATE CATALOG command 2、Support drop catalog 3、Support update catalog ### Why are the changes needed? Fix: #3601 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
diqiu50
added a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…talog to Trino by Trino SQL command (apache#3602) ### What changes were proposed in this pull request? 1、Support automatically loading catalog to Trino by using CREATE CATALOG command 2、Support drop catalog 3、Support update catalog ### Why are the changes needed? Fix: apache#3601 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? NO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1、Support automatically loading catalog to Trino by using CREATE CATALOG command
2、Support drop catalog
3、Support update catalog
Why are the changes needed?
Fix: #3601
Does this PR introduce any user-facing change?
NO
How was this patch tested?
NO