[#3966] feat(core): add cloud and region property for catalog #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Jun 26, 2024
| @@ -15,6 +15,9 @@ | |||
| @Evolving | |||
| public abstract class BaseCatalogPropertiesMetadata extends BasePropertiesMetadata { | |||
|
|
|||
| public static final String CLOUD_NAME = "cloud.name"; | |||
| public static final String CLOUD_REGION_CODE = "cloud.region-code"; | |||
There was a problem hiding this comment.
It is better to define these two reserved properties in Catalog interface. So users will know how to use it. Also don't forget to update the doc.
mchades
force-pushed
the
region-prop
branch
2 times, most recently
from
b580687 to
8928e01
Compare
jerryshao
reviewed
Jun 26, 2024
| | Property Name | Description | Default Value | Required | Since Version | | ||
| |---------------------|-----------------------------------------------------------------------------------------------------------------------------------------|---------------|----------|---------------| | ||
| | `cloud.name` | The property to specify the cloud that the catalog is running on. The valid values are `aws`, `azure`, `gcp`, `on_premise` and `other`. | (none) | No | 0.6.0 | | ||
| | `cloud.region-code` | The property to specify the region code of the cloud that the caatlog is running on. | (none) | No | 0.6.0 | |
There was a problem hiding this comment.
There's a chapter in gravitino-server-config.md describing about the common catalog properties, maybe you should combine them together.
There was a problem hiding this comment.
Maybe you can also move to here.
jerryshao
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
cloud.nameandcloud.region-codeproperty for catalogWhy are the changes needed?
Fix: #3966
Does this PR introduce any user-facing change?
yes, introduce some limitations of
cloud.namepropertyHow was this patch tested?
tests added