[#4279] feat(client-python): Add the getFileLocation interface code skeleton in Python Client
#4373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
force-pushed
the
add-get-fileset-context-api-in-python
branch
4 times, most recently
from
6a8db00 to
ebf6ed7
Compare
xloya
changed the title
getFilesetContext interface in Python ClientgetFileLocation interface in Python Client
xloya
changed the title
getFileLocation interface in Python ClientgetFileLocation interface code skeleton in Python Client
xloya
force-pushed
the
add-get-fileset-context-api-in-python
branch
2 times, most recently
from
39d9eea to
b30d18b
Compare
xloya
force-pushed
the
add-get-fileset-context-api-in-python
branch
from
b30d18b to
307d776
Compare
|
@jerryshao @noidname01 This PR is ready for review, please take a look of this when you have time, thanks. |
jerryshao
reviewed
Sep 23, 2024
| """An enum class containing fileset data operations that supported.""" | ||
|
|
||
| CREATE = "CREATE" | ||
| """ This data operation means that create a new file. |
There was a problem hiding this comment.
I think the comment can be simplified as "Creates a new file", "Options a file", that should be enough.
jerryshao
reviewed
Sep 24, 2024
|
|
||
|
|
||
| class CallerContext: | ||
| """A class defining the caller context for auditing coarse granularity operations.""" |
There was a problem hiding this comment.
"auditing coarse-grained operations."
|
Generally LGTM, just one comment. |
jerryshao
approved these changes
Sep 24, 2024
jerryshao
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added an interface code skeleton in Python Client for obtaining the file location so that the client can report some necessary information for the server to audit and simplify some check logics in Python GVFS later. Depend on #4320.
Why are the changes needed?
Fix: #4279
How was this patch tested?
Add UTs and ITs.