-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 43MB #4531
Conversation
f85d200
to
070c07d
Compare
070c07d
to
52e19f1
Compare
Can you please list all the jars after you excluded @mchades? |
@jerryshao FYI: |
52e19f1
to
078ed87
Compare
I'm definitely sure that there're many libs from Hive can be excluded, like llap, so please carefully check them one by one. |
I have excluded llap before, but encountered an error, so let me try to understand the error again. |
078ed87
to
eddbda2
Compare
@jerryshao ![]() ![]() |
6bbab8b
to
dd66565
Compare
dd66565
to
4c79e0a
Compare
Do we need that "hive-vector-code-gen"? |
implementation(libs.javax.jaxb.api) { | ||
exclude("*") | ||
} | ||
implementation(libs.rome) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to introduce some dependencies like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I excluded some Hive catalog dependencies, RangerHiveIT encountered a ClassNotFoundException, so I introduced these dependencies to fix it.
I think the root cause is that the AuthRanger plugin uses the same class loader as the Hive catalog. Previously, the Ranger plugin used dependencies of the Hive catalog.
woodstox-core = "5.3.0" | ||
mail = "1.4.1" | ||
rome = "1.0" | ||
jettison = "1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to add these new dependencies, we should also update the license.bin file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What changes were proposed in this pull request?
remove some unnecessary dependencies
Why are the changes needed?
Fix: #4528
Does this PR introduce any user-facing change?
no
How was this patch tested?
CI passed