Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 43MB #4531

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

mchades
Copy link
Contributor

@mchades mchades commented Aug 15, 2024

What changes were proposed in this pull request?

remove some unnecessary dependencies

Why are the changes needed?

Fix: #4528

Does this PR introduce any user-facing change?

no

How was this patch tested?

CI passed

@mchades mchades self-assigned this Aug 15, 2024
@mchades mchades changed the title [#4528] improvement(hive-catalog): reduce have catalog libs size from 146MB to 60MB [#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 60MB Aug 15, 2024
@mchades mchades changed the title [#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 60MB [#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 76MB Aug 15, 2024
@mchades mchades marked this pull request as ready for review August 16, 2024 02:01
@jerryshao
Copy link
Contributor

Can you please list all the jars after you excluded @mchades?

@mchades
Copy link
Contributor Author

mchades commented Aug 26, 2024

@jerryshao FYI:
before:
image
image
image
image
image

after:
image
image
image
image

@jerryshao
Copy link
Contributor

I'm definitely sure that there're many libs from Hive can be excluded, like llap, so please carefully check them one by one.

@mchades
Copy link
Contributor Author

mchades commented Aug 27, 2024

I'm definitely sure that there're many libs from Hive can be excluded, like llap, so please carefully check them one by one.

I have excluded llap before, but encountered an error, so let me try to understand the error again.

@mchades mchades changed the title [#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 76MB [#4528] improvement(hive-catalog): reduce hive catalog libs size from 146MB to 43MB Aug 29, 2024
@mchades
Copy link
Contributor Author

mchades commented Aug 29, 2024

@jerryshao
after the last commit, the jars list of hive catalog:

image image

@jerryshao
Copy link
Contributor

Do we need that "hive-vector-code-gen"?

implementation(libs.javax.jaxb.api) {
exclude("*")
}
implementation(libs.rome)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to introduce some dependencies like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I excluded some Hive catalog dependencies, RangerHiveIT encountered a ClassNotFoundException, so I introduced these dependencies to fix it.

I think the root cause is that the AuthRanger plugin uses the same class loader as the Hive catalog. Previously, the Ranger plugin used dependencies of the Hive catalog.

woodstox-core = "5.3.0"
mail = "1.4.1"
rome = "1.0"
jettison = "1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to add these new dependencies, we should also update the license.bin file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@mchades mchades requested a review from xunliu August 30, 2024 02:25
Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerryshao jerryshao merged commit c01edab into apache:main Aug 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Shrink Hive catalog binary package size
2 participants