[#4718] fix(iceberg): use unified logic to transform catalog backend name to handle the renaming of catalog #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
diqiu50
reviewed
Sep 14, 2024
docs/lakehouse-iceberg-catalog.md
Outdated
| | `catalog-backend` | Catalog backend of Gravitino Iceberg catalog. Supports `hive` or `jdbc` or `rest`. | (none) | Yes | 0.2.0 | | ||
| | `uri` | The URI configuration of the Iceberg catalog. `thrift://127.0.0.1:9083` or `jdbc:postgresql://127.0.0.1:5432/db_name` or `jdbc:mysql://127.0.0.1:3306/metastore_db` or `http://127.0.0.1:9001`. | (none) | Yes | 0.2.0 | | ||
| | `warehouse` | Warehouse directory of catalog. `file:///user/hive/warehouse-hive/` for local fs or `hdfs://namespace/hdfs/path` for HDFS. | (none) | Yes | 0.2.0 | | ||
| | `catalog-backend-name` | The catalog name passed to underlying Iceberg catalog backend. Catalog name in JDBC backend is used to isolate namespace and tables. | `catalog-backend` property value. | No | 0.5.2 | |
There was a problem hiding this comment.
The default value is "catalog-backend" or "catalog-backend property value".
There was a problem hiding this comment.
The property value of catalog-backend, and add an example
There was a problem hiding this comment.
Is it better to use only values like catalog-backend?
There was a problem hiding this comment.
seems a little odd to use catalog-backend for a catalog name
| String catalogBackend = catalogProperties.get(IcebergConstants.CATALOG_BACKEND); | ||
| return Optional.ofNullable(catalogBackend) | ||
| .map(s -> s.toLowerCase(Locale.ROOT)) | ||
| .orElse("memory"); |
There was a problem hiding this comment.
What's the meaning of the default value `memory"?
There was a problem hiding this comment.
the default catalog backend is memory
.../main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergConnectorAdapter.java
Show resolved
Hide resolved
diqiu50
reviewed
Sep 19, 2024
| | `catalog-backend` | Catalog backend of Gravitino Iceberg catalog. Supports `hive` or `jdbc` or `rest`. | (none) | Yes | 0.2.0 | | ||
| | `uri` | The URI configuration of the Iceberg catalog. `thrift://127.0.0.1:9083` or `jdbc:postgresql://127.0.0.1:5432/db_name` or `jdbc:mysql://127.0.0.1:3306/metastore_db` or `http://127.0.0.1:9001`. | (none) | Yes | 0.2.0 | | ||
| | `warehouse` | Warehouse directory of catalog. `file:///user/hive/warehouse-hive/` for local fs or `hdfs://namespace/hdfs/path` for HDFS. | (none) | Yes | 0.2.0 | | ||
| | `catalog-backend-name` | The catalog name passed to underlying Iceberg catalog backend. Catalog name in JDBC backend is used to isolate namespace and tables. | The property value of `catalog-backend`, like `jdbc` for JDBC catalog backend. | No | 0.5.2 | | ||
|
|
There was a problem hiding this comment.
Is the default catalog backend memory
There was a problem hiding this comment.
It depondes on catalog-backend, not memory
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
…name to handle the renaming of catalog (#4900) ### What changes were proposed in this pull request? 1. Spark,Trino, Iceberg catalog and Iceberg REST server use `getCatalogBackendName` to get catalog backend name. 2. change the default backend name to catalog backend, like `jdbc`, it will not change after rename. ### Why are the changes needed? Fix: #4718 ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? 1. create a jdbc catalog with catalog backend name, check whether can see the schema after rename 1. create a jdbc catalog without catalog backend name, check whether can see the schema after rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
getCatalogBackendNameto get catalog backend name.jdbc, it will not change after rename.Why are the changes needed?
Fix: #4718
Does this PR introduce any user-facing change?
Yes
How was this patch tested?