-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5112] feat(core): support pre event for event listener systems #5110
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
core/src/main/java/org/apache/gravitino/listener/api/event/BaseEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import javax.annotation.Nullable; | ||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
|
||
/** | ||
* The abstract base class for all events. It encapsulates common information such as the user who | ||
* generated the event and the identifier for the resource associated with the event. Subclasses | ||
* should provide specific details related to their individual event types. | ||
*/ | ||
@DeveloperApi | ||
public abstract class BaseEvent { | ||
private final String user; | ||
@Nullable private final NameIdentifier identifier; | ||
private final long eventTime; | ||
|
||
/** | ||
* Constructs an Event instance with the specified user and resource identifier details. | ||
* | ||
* @param user The user associated with this event. It provides context about who triggered the | ||
* event. | ||
* @param identifier The resource identifier associated with this event. This may refer to various | ||
* types of resources such as a metalake, catalog, schema, or table, etc. | ||
*/ | ||
protected BaseEvent(String user, NameIdentifier identifier) { | ||
this.user = user; | ||
this.identifier = identifier; | ||
this.eventTime = System.currentTimeMillis(); | ||
} | ||
|
||
/** | ||
* Retrieves the user associated with this event. | ||
* | ||
* @return A string representing the user associated with this event. | ||
*/ | ||
public String user() { | ||
return user; | ||
} | ||
|
||
/** | ||
* Retrieves the resource identifier associated with this event. | ||
* | ||
* <p>For list operations within a namespace, the identifier is the identifier corresponds to that | ||
* namespace. For metalake list operation, identifier is null. | ||
* | ||
* @return A NameIdentifier object that represents the resource, like a metalake, catalog, schema, | ||
* table, etc., associated with the event. | ||
*/ | ||
@Nullable | ||
public NameIdentifier identifier() { | ||
return identifier; | ||
} | ||
|
||
/** | ||
* Returns the timestamp when the event was created. | ||
* | ||
* @return The event creation time in milliseconds since epoch. | ||
*/ | ||
public long eventTime() { | ||
return eventTime; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we change to
default
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after supporting pre event, the user who only interest on pre event, could only implement onPreEvent interface, no need to implement onPostEvent interface