[#4599][#4809] feat(core): Add tag support for column #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
changed the title
jerryshao
added
need backport
mchades
reviewed
Oct 24, 2024
core/src/main/java/org/apache/gravitino/storage/relational/service/MetadataObjectService.java
Show resolved
Hide resolved
mchades
reviewed
Oct 24, 2024
|
Overall LGTM. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
### What changes were proposed in this pull request? This PR proposes to add tag support for columns. ### Why are the changes needed? With this PR, user could add and remove tags in the column level. Fix: #4599 Fix: #4809 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add new UT and IT to test. --------- Co-authored-by: Qi Yu <[email protected]>
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…ache#5186) ### What changes were proposed in this pull request? This PR proposes to add tag support for columns. ### Why are the changes needed? With this PR, user could add and remove tags in the column level. Fix: apache#4599 Fix: apache#4809 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add new UT and IT to test. --------- Co-authored-by: Qi Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add tag support for columns.
Why are the changes needed?
With this PR, user could add and remove tags in the column level.
Fix: #4599
Fix: #4809
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add new UT and IT to test.