[#5550] feat(core): add partition pre event to Gravitino event #5590

LiuQhahah · 2024-11-15T11:42:59Z

What changes were proposed in this pull request?

add corresponding PartitionPreEvent
generate pre-event in PartitionEventDispatcher
add test in TestPartitionEvent
add document in gravitino-server-config.md

Why are the changes needed?

Fix: #5550

Does this PR introduce any user-facing change?

NO

How was this patch tested?

UT

…itino-server # Conflicts: # docs/gravitino-server-config.md

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java

core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java

…itino-server

jerryshao · 2024-11-21T04:12:43Z

Please update the PR to fix the conflict, @LiuQhahah .

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java

core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java

…itino-server # Conflicts: # docs/gravitino-server-config.md

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java

FANNG1 · 2024-11-21T12:42:11Z

@LiuQhahah as #5580 is merged first, could you rebase the code and add more work:

add operationType method to all specific partition event.

 @Override
  public OperationType operationType() {
    // change the type according to the event type
    return OperationType.LIST_PARTITION;
  }

add partition type test in TestPartitionEvent for partition pre event like TestTableEvent

LiuQhahah · 2024-11-22T06:40:15Z

@LiuQhahah as #5580 is merged first, could you rebase the code and add more work:

add operationType method to all specific partition event.
 @Override
  public OperationType operationType() {
    // change the type according to the event type
    return OperationType.LIST_PARTITION;
  }
add partition type test in TestPartitionEvent for partition pre event like TestTableEvent

got it.
I will do it tonight.
Thanks,
Qiang

…itino-server # Conflicts: # core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java

FANNG1 · 2024-11-23T14:25:29Z

core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java

+    partitionInfo = ((AddPartitionPreEvent) preEvent).createdPartitionRequest();
+    checkPartitionInfo(partitionInfo, partition);
+    Assertions.assertEquals(OperationType.ADD_PARTITION, event.operationType());
+    Assertions.assertEquals(OperationStatus.SUCCESS, event.operationStatus());


The operation status should be UNPROCESSED not SUCCESS for pre event

we should check preEvent not event here

FANNG1 · 2024-11-23T14:27:37Z

@LiuQhahah ,LGTM except minor comments, could you fix it ?

LiuQhahah · 2024-11-24T10:34:43Z

@LiuQhahah ,LGTM except minor comments, could you fix it ?

Hi @FANNG1

I have fixed the issue.

Please review it again.
Thanks,
Qiang

jerryshao · 2024-11-25T03:16:04Z

There're some UT failures that need to be fixed.

…itino-server

LiuQhahah · 2024-11-25T07:33:49Z

HI @jerryshao @FANNG1

I have updated it.
please help to review it again.
sorry.
Thanks,
Qiang

FANNG1 · 2024-11-25T08:46:44Z

@LiuQhahah merged to main, thanks for your contribution!

apache#5550-add-partition-pre-event-for-Gravitino-server

86c28be

LiuQhahah changed the title ~~#5550-add-partition-pre-event-for-Gravitino-server~~ [#5550] feat(core): add partition pre event to Gravitino event Nov 15, 2024

xunliu requested a review from FANNG1 November 19, 2024 03:51

xunliu assigned LiuQhahah Nov 19, 2024

LiuQhahah added 2 commits November 19, 2024 14:56

Merge branch 'main' into apache#5550-add-partition-pre-event-for-Grav…

58766a7

…itino-server # Conflicts: # docs/gravitino-server-config.md

apache#5550 format code style

b794ec6

FANNG1 reviewed Nov 19, 2024

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java Outdated Show resolved Hide resolved

core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java Outdated Show resolved Hide resolved

LiuQhahah added 2 commits November 20, 2024 22:42

Merge branch 'main' into apache#5550-add-partition-pre-event-for-Grav…

82ea65f

…itino-server

apache#5550 update variable name and make PartitionPreEvent abstract

8394eab

FANNG1 previously approved these changes Nov 21, 2024

View reviewed changes

tengqm reviewed Nov 21, 2024

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java Show resolved Hide resolved

tengqm reviewed Nov 21, 2024

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java Show resolved Hide resolved

Merge branch 'main' into apache#5550-add-partition-pre-event-for-Grav…

a15df66

…itino-server # Conflicts: # docs/gravitino-server-config.md

LiuQhahah dismissed FANNG1’s stale review via a15df66 November 21, 2024 10:26

tengqm reviewed Nov 21, 2024

View reviewed changes

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java Show resolved Hide resolved

core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java Show resolved Hide resolved

LiuQhahah added 4 commits November 22, 2024 19:29

Merge branch 'main' into apache#5550-add-partition-pre-event-for-Grav…

5573d19

…itino-server # Conflicts: # core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java

apache#5550 add operationType

abb2fe4

apache#5550 add test for operationType

f39079a

apache#5550 format style with spotlessApply

f07e47c

FANNG1 reviewed Nov 23, 2024

View reviewed changes

apache#5550 check with preEvent instead of event

6cfb3c7

FANNG1 previously approved these changes Nov 25, 2024

View reviewed changes

apache#5550 the OperationStatus is UNPROCESSED instead of SUCCESS

14fe23c

LiuQhahah dismissed FANNG1’s stale review via 14fe23c November 25, 2024 07:32

Merge branch 'main' into apache#5550-add-partition-pre-event-for-Grav…

7382527

…itino-server

FANNG1 approved these changes Nov 25, 2024

View reviewed changes

FANNG1 merged commit c1b9885 into apache:main Nov 25, 2024
26 checks passed

LiuQhahah deleted the #5550-add-partition-pre-event-for-Gravitino-server branch November 25, 2024 09:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#5550] feat(core): add partition pre event to Gravitino event #5590

[#5550] feat(core): add partition pre event to Gravitino event #5590

LiuQhahah commented Nov 15, 2024 •

edited by jerryshao

Loading

jerryshao commented Nov 21, 2024

FANNG1 commented Nov 21, 2024 •

edited

Loading

LiuQhahah commented Nov 22, 2024

FANNG1 Nov 23, 2024

FANNG1 Nov 23, 2024

FANNG1 commented Nov 23, 2024

LiuQhahah commented Nov 24, 2024

jerryshao commented Nov 25, 2024

LiuQhahah commented Nov 25, 2024

FANNG1 commented Nov 25, 2024

[#5550] feat(core): add partition pre event to Gravitino event #5590

[#5550] feat(core): add partition pre event to Gravitino event #5590

Conversation

LiuQhahah commented Nov 15, 2024 • edited by jerryshao Loading

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

jerryshao commented Nov 21, 2024

FANNG1 commented Nov 21, 2024 • edited Loading

LiuQhahah commented Nov 22, 2024

FANNG1 Nov 23, 2024

Choose a reason for hiding this comment

FANNG1 Nov 23, 2024

Choose a reason for hiding this comment

FANNG1 commented Nov 23, 2024

LiuQhahah commented Nov 24, 2024

jerryshao commented Nov 25, 2024

LiuQhahah commented Nov 25, 2024

FANNG1 commented Nov 25, 2024

LiuQhahah commented Nov 15, 2024 •

edited by jerryshao

Loading

FANNG1 commented Nov 21, 2024 •

edited

Loading