Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5453] subtask(web): support for table column types with parameters #5592

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

orenccl
Copy link
Collaborator

@orenccl orenccl commented Nov 16, 2024

What changes were proposed in this pull request?

Create and update column types ['char', 'varchar', 'fixed', decimal] with parameters

Why are the changes needed?

Close: #5453

Does this PR introduce any user-facing change?

four more table type column type on selection

How was this patch tested?

Create part 1
chrome-capture-2024-11-16

Create part 2
chrome-capture-2024-11-16 (1)

Update
chrome-capture-2024-11-16 (2)

@LauraXia123
Copy link
Collaborator

image Can be displayed back while editing?

@orenccl
Copy link
Collaborator Author

orenccl commented Nov 18, 2024

image Can be displayed back while editing?

No problem, updated.

@orenccl orenccl force-pushed the subtask/tableColumnParam branch from 98ad5c3 to bf5c688 Compare November 18, 2024 15:14
@LauraXia123
Copy link
Collaborator

Thank you very much for your contribution. LGTM

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xunliu xunliu merged commit bcc4c42 into apache:main Nov 19, 2024
23 checks passed
@orenccl orenccl deleted the subtask/tableColumnParam branch November 19, 2024 03:51
TungYuChiang pushed a commit to TungYuChiang/gravitino that referenced this pull request Nov 19, 2024
…eters (apache#5592)

### What changes were proposed in this pull request?

Create and update column types `['char', 'varchar', 'fixed', `decimal`]`
with parameters

### Why are the changes needed?

Close: apache#5453 

### Does this PR introduce _any_ user-facing change?

four more table type column type on selection 

### How was this patch tested?

Create part 1

![chrome-capture-2024-11-16](https://github.com/user-attachments/assets/befec5c6-0afb-469a-928f-f6fa49a792f2)

Create part 2
![chrome-capture-2024-11-16
(1)](https://github.com/user-attachments/assets/efcacfdc-18e0-44b4-b80d-8caf65d71df2)

Update
![chrome-capture-2024-11-16
(2)](https://github.com/user-attachments/assets/cec70ac7-cbd5-411f-8970-27d854fbc4d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] Support for table column types with parameters
3 participants