[#5675] feat(auth): Chain authorization plugin (part-1) #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
changed the title
xunliu
force-pushed
the
issue-5675
branch
2 times, most recently
from
b087a97 to
d501acc
Compare
xunliu
changed the title
mchades
reviewed
Nov 28, 2024
| @@ -64,7 +65,8 @@ private PropertyEntry( | |||
| Function<String, T> decoder, | |||
| Function<T, String> encoder, | |||
| boolean hidden, | |||
| boolean reserved) { | |||
| boolean reserved, | |||
| boolean wildcard) { | |||
There was a problem hiding this comment.
you also need to update the javaDoc on the method.
The boolean parameter name wildcard is not quite suitable, suggest to use useWildcard, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #5675
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Add UTs.