Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5790] auth(chain): Chain authorization properties #5791

Merged
merged 10 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.gravitino.authorization.ranger;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

/**
* The properties for Chain authorization plugin. <br>
* <br>
* Configuration Example: <br>
* "authorization.chain.plugins" = "hive1,hdfs1" <br>
* "authorization.chain.hive1.provider" = "ranger"; <br>
* "authorization.chain.hive1.ranger.service.type" = "HadoopSQL"; <br>
* "authorization.chain.hive1.ranger.service.name" = "hiveDev"; <br>
* "authorization.chain.hive1.ranger.auth.type" = "simple"; <br>
* "authorization.chain.hive1.ranger.admin.url" = "http://localhost:6080"; <br>
* "authorization.chain.hive1.ranger.username" = "admin"; <br>
* "authorization.chain.hive1.ranger.password" = "admin"; <br>
* "authorization.chain.hdfs1.provider" = "ranger"; <br>
* "authorization.chain.hdfs1.ranger.service.type" = "HDFS"; <br>
* "authorization.chain.hdfs1.ranger.service.name" = "hdfsDev"; <br>
* "authorization.chain.hdfs1.ranger.auth.type" = "simple"; <br>
* "authorization.chain.hdfs1.ranger.admin.url" = "http://localhost:6080"; <br>
* "authorization.chain.hdfs1.ranger.username" = "admin"; <br>
* "authorization.chain.hdfs1.ranger.password" = "admin"; <br>
*/
public class ChainAuthorizationProperties {
public static final String PLUGINS_SPLITTER = ",";
/** Chain authorization plugin names */
public static final String CHAIN_PLUGINS_PROPERTIES_KEY = "authorization.chain.plugins";

/** Chain authorization plugin provider */
public static final String CHAIN_PROVIDER = "authorization.chain.*.provider";

static Map<String, String> fetchAuthPluginProperties(
String pluginName, Map<String, String> properties) {
Preconditions.checkArgument(
properties.containsKey(CHAIN_PLUGINS_PROPERTIES_KEY)
&& properties.get(CHAIN_PLUGINS_PROPERTIES_KEY) != null,
String.format("%s is required", CHAIN_PLUGINS_PROPERTIES_KEY));

String[] pluginNames = properties.get(CHAIN_PLUGINS_PROPERTIES_KEY).split(PLUGINS_SPLITTER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential NPE when properties.get(CHAIN_PLUGINS_PROPERTIES_KEY) return null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

Preconditions.checkArgument(
Arrays.asList(pluginNames).contains(pluginName),
String.format("pluginName %s must be one of %s", pluginName, Arrays.toString(pluginNames)));

String regex = "^authorization\\.chain\\.(" + pluginName + ")\\..*";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitate about regex expression. Usually regex expression will make code hard to understand. Is it neccessary although the regex epression seems simple.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to use regular expressions:

  1. Check whether the plugin name meets requirements. For example, the plugin name cannot be included . symbol.
  2. Check that the plugin name must be one of several values specified
  3. Delete plugin name from the chain attribute to generate plugin attribute configuration.
    Only the simplest regular expressions are used here, which I don't think is a problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can get the configuration by configuration prefix like authorization.pluginName.xxxx.

Copy link
Member Author

@xunliu xunliu Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChainAuthorizationProperties is just a regular expression.

"authorization.chain.plugins" = "hive1,hdfs1" <br>
"authorization.chain.*.provider" = "ranger"; <br>
"authorization.chain.*.ranger.service.type" = "HadoopSQL"; <br>
"authorization.chain.*.ranger.service.name" = "hiveDev"; <br>
"authorization.chain.*.ranger.auth.type" = "simple"; <br>
"authorization.chain.*.ranger.admin.url" = "http://localhost:6080"; <br>
"authorization.chain.*.ranger.username" = "admin"; <br>
"authorization.chain.*.ranger.password" = "admin"; <br>

We can use ChainAuthorizationProperties to configuration multiple plugin properties.:

Configuration Example: <br>
"authorization.chain.plugins" = "hive1,hdfs1" <br>
"authorization.chain.hive1.provider" = "ranger"; <br>
"authorization.chain.hive1.ranger.service.type" = "HadoopSQL"; <br>
"authorization.chain.hive1.ranger.service.name" = "hiveDev"; <br>
"authorization.chain.hive1.ranger.auth.type" = "simple"; <br>
"authorization.chain.hive1.ranger.admin.url" = "http://localhost:6080"; <br>
"authorization.chain.hive1.ranger.username" = "admin"; <br>
"authorization.chain.hive1.ranger.password" = "admin"; <br>
"authorization.chain.hdfs1.provider" = "ranger"; <br>
"authorization.chain.hdfs1.ranger.service.type" = "HDFS"; <br>
"authorization.chain.hdfs1.ranger.service.name" = "hdfsDev"; <br>
"authorization.chain.hdfs1.ranger.auth.type" = "simple"; <br>
"authorization.chain.hdfs1.ranger.admin.url" = "http://localhost:6080"; <br>
"authorization.chain.hdfs1.ranger.username" = "admin"; <br>
"authorization.chain.hdfs1.ranger.password" = "admin"; <br>

Pattern pattern = Pattern.compile(regex);

Map<String, String> filteredProperties = new HashMap<>();
for (Map.Entry<String, String> entry : properties.entrySet()) {
Matcher matcher = pattern.matcher(entry.getKey());
if (matcher.matches()) {
filteredProperties.put(entry.getKey(), entry.getValue());
}
}

String removeRegex = "^authorization\\.chain\\.(" + pluginName + ")\\.";
Pattern removePattern = Pattern.compile(removeRegex);

Map<String, String> resultProperties = new HashMap<>();
for (Map.Entry<String, String> entry : filteredProperties.entrySet()) {
Matcher removeMatcher = removePattern.matcher(entry.getKey());
if (removeMatcher.find()) {
resultProperties.put(removeMatcher.replaceFirst("authorization."), entry.getValue());
}
}

return resultProperties;
}

public static void validate(Map<String, String> properties) {
Preconditions.checkArgument(
properties.containsKey(CHAIN_PLUGINS_PROPERTIES_KEY),
String.format("%s is required", CHAIN_PLUGINS_PROPERTIES_KEY));
List<String> pluginNames =
Arrays.stream(properties.get(CHAIN_PLUGINS_PROPERTIES_KEY).split(PLUGINS_SPLITTER))
.map(String::trim)
.collect(Collectors.toList());
Preconditions.checkArgument(
!pluginNames.isEmpty(),
String.format("%s must have at least one plugin name", CHAIN_PLUGINS_PROPERTIES_KEY));
Preconditions.checkArgument(
pluginNames.size() == pluginNames.stream().distinct().count(),
"Duplicate plugin name in %s: %s",
CHAIN_PLUGINS_PROPERTIES_KEY,
pluginNames);
pluginNames.stream()
.filter(v -> v.contains("."))
.forEach(
v -> {
throw new IllegalArgumentException(
String.format(
"Plugin name cannot be contain `.` character in the `%s = %s`.",
CHAIN_PLUGINS_PROPERTIES_KEY, properties.get(CHAIN_PLUGINS_PROPERTIES_KEY)));
});

Pattern pattern = Pattern.compile("^authorization\\.chain\\..*\\..*$");
Map<String, String> filteredProperties =
properties.entrySet().stream()
.filter(entry -> pattern.matcher(entry.getKey()).matches())
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));

String pluginNamesPattern = String.join("|", pluginNames);
Pattern patternPluginNames =
Pattern.compile("^authorization\\.chain\\.(" + pluginNamesPattern + ")\\..*$");
for (String key : filteredProperties.keySet()) {
Matcher matcher = patternPluginNames.matcher(key);
Preconditions.checkArgument(
matcher.matches(),
"The key %s does not match the pattern %s",
key,
patternPluginNames.pattern());
}

// Generate regex patterns from wildcardProperties
List<String> wildcardProperties = ImmutableList.of(CHAIN_PROVIDER);
for (String pluginName : pluginNames) {
List<Pattern> patterns =
wildcardProperties.stream()
.map(wildcard -> "^" + wildcard.replace("*", pluginName) + "$")
.map(Pattern::compile)
.collect(Collectors.toList());
// Validate properties keys
for (Pattern pattern1 : patterns) {
boolean matches =
filteredProperties.keySet().stream().anyMatch(key -> pattern1.matcher(key).matches());
Preconditions.checkArgument(
matches,
"Missing required properties %s for plugin: %s",
filteredProperties,
pattern1.pattern());
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
*/
package org.apache.gravitino.authorization.ranger;

import static org.apache.gravitino.authorization.ranger.RangerAuthorizationProperties.RANGER_SERVICE_TYPE;

import com.google.common.base.Preconditions;
import java.util.Map;
import org.apache.gravitino.connector.authorization.AuthorizationPlugin;
import org.apache.gravitino.connector.authorization.BaseAuthorization;
Expand All @@ -31,16 +34,18 @@ public String shortName() {

@Override
protected AuthorizationPlugin newPlugin(
String metalake, String catalogProvider, Map<String, String> config) {
switch (catalogProvider) {
case "hive":
case "lakehouse-iceberg":
case "lakehouse-paimon":
return RangerAuthorizationHadoopSQLPlugin.getInstance(metalake, config);
case "hadoop":
return RangerAuthorizationHDFSPlugin.getInstance(metalake, config);
String metalake, String catalogProvider, Map<String, String> properties) {
Preconditions.checkArgument(
properties.containsKey(RANGER_SERVICE_TYPE),
String.format("%s is required", RANGER_SERVICE_TYPE));
String serviceType = properties.get(RANGER_SERVICE_TYPE).toUpperCase();
switch (serviceType) {
case "HADOOPSQL":
return RangerAuthorizationHadoopSQLPlugin.getInstance(metalake, properties);
case "HDFS":
return RangerAuthorizationHDFSPlugin.getInstance(metalake, properties);
default:
throw new IllegalArgumentException("Unknown catalog provider: " + catalogProvider);
throw new IllegalArgumentException("Unsupported service type: " + serviceType);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
import org.apache.gravitino.authorization.ranger.reference.VXGroupList;
import org.apache.gravitino.authorization.ranger.reference.VXUser;
import org.apache.gravitino.authorization.ranger.reference.VXUserList;
import org.apache.gravitino.connector.AuthorizationPropertiesMeta;
import org.apache.gravitino.connector.authorization.AuthorizationPlugin;
import org.apache.gravitino.exceptions.AuthorizationPluginException;
import org.apache.gravitino.meta.AuditInfo;
Expand Down Expand Up @@ -88,17 +87,13 @@ public abstract class RangerAuthorizationPlugin

protected RangerAuthorizationPlugin(String metalake, Map<String, String> config) {
this.metalake = metalake;
String rangerUrl = config.get(AuthorizationPropertiesMeta.RANGER_ADMIN_URL);
String authType = config.get(AuthorizationPropertiesMeta.RANGER_AUTH_TYPE);
rangerAdminName = config.get(AuthorizationPropertiesMeta.RANGER_USERNAME);
RangerAuthorizationProperties.validate(config);
String rangerUrl = config.get(RangerAuthorizationProperties.RANGER_ADMIN_URL);
String authType = config.get(RangerAuthorizationProperties.RANGER_AUTH_TYPE);
rangerAdminName = config.get(RangerAuthorizationProperties.RANGER_USERNAME);
// Apache Ranger Password should be minimum 8 characters with min one alphabet and one numeric.
String password = config.get(AuthorizationPropertiesMeta.RANGER_PASSWORD);
rangerServiceName = config.get(AuthorizationPropertiesMeta.RANGER_SERVICE_NAME);
Preconditions.checkArgument(rangerUrl != null, "Ranger admin URL is required");
Preconditions.checkArgument(authType != null, "Ranger auth type is required");
Preconditions.checkArgument(rangerAdminName != null, "Ranger username is required");
Preconditions.checkArgument(password != null, "Ranger password is required");
Preconditions.checkArgument(rangerServiceName != null, "Ranger service name is required");
String password = config.get(RangerAuthorizationProperties.RANGER_PASSWORD);
rangerServiceName = config.get(RangerAuthorizationProperties.RANGER_SERVICE_NAME);
rangerClient = new RangerClientExtension(rangerUrl, authType, rangerAdminName, password);

rangerHelper =
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.gravitino.authorization.ranger;

import com.google.common.base.Preconditions;
import java.util.Map;

/** The properties for Ranger authorization plugin. */
public class RangerAuthorizationProperties {
/** Ranger admin web URIs */
public static final String RANGER_ADMIN_URL = "authorization.ranger.admin.url";

/** Ranger service type */
public static final String RANGER_SERVICE_TYPE = "authorization.ranger.service.type";

/** Ranger service name */
public static final String RANGER_SERVICE_NAME = "authorization.ranger.service.name";

/** Ranger authentication type kerberos or simple */
public static final String RANGER_AUTH_TYPE = "authorization.ranger.auth.type";

/**
* Ranger admin web login username(auth_type=simple), or kerberos principal(auth_type=kerberos)
*/
public static final String RANGER_USERNAME = "authorization.ranger.username";

/**
* Ranger admin web login user password(auth_type=simple), or path of the keytab
* file(auth_type=kerberos)
*/
public static final String RANGER_PASSWORD = "authorization.ranger.password";

public static void validate(Map<String, String> properties) {
Preconditions.checkArgument(
properties.containsKey(RANGER_ADMIN_URL),
String.format("%s is required", RANGER_ADMIN_URL));
Preconditions.checkArgument(
properties.containsKey(RANGER_SERVICE_TYPE),
String.format("%s is required", RANGER_SERVICE_TYPE));
Preconditions.checkArgument(
properties.containsKey(RANGER_SERVICE_NAME),
String.format("%s is required", RANGER_SERVICE_NAME));
Preconditions.checkArgument(
properties.containsKey(RANGER_AUTH_TYPE),
String.format("%s is required", RANGER_AUTH_TYPE));
Preconditions.checkArgument(
properties.containsKey(RANGER_USERNAME), String.format("%s is required", RANGER_USERNAME));
Preconditions.checkArgument(
properties.containsKey(RANGER_PASSWORD), String.format("%s is required", RANGER_PASSWORD));
Preconditions.checkArgument(
properties.get(RANGER_ADMIN_URL) != null,
String.format("%s is required", RANGER_ADMIN_URL));
Preconditions.checkArgument(
properties.get(RANGER_SERVICE_NAME) != null,
String.format("%s is required", RANGER_SERVICE_NAME));
Preconditions.checkArgument(
properties.get(RANGER_AUTH_TYPE) != null,
String.format("%s is required", RANGER_AUTH_TYPE));
Preconditions.checkArgument(
properties.get(RANGER_USERNAME) != null, String.format("%s is required", RANGER_USERNAME));
Preconditions.checkArgument(
properties.get(RANGER_PASSWORD) != null, String.format("%s is required", RANGER_PASSWORD));
}
}
Loading
Loading