[#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a metalake when the required parameter is missing. Currently, when a metalake is created without specifying the metalake argument, the message "Cannot parse a null or empty identifier" is displayed. This message is unclear and lacks helpful guidance for the user. Update the message to: "! metalake is not defined" to make it more user-friendly and informative. fix some change
|
@justinmclean @xunliu hi guys, Could you please take a look when you have time? |
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
Outdated
Show resolved
Hide resolved
Use CommandEntities replace MetadataObject.Type
|
Hi @justinmclean , plz review this pr again, I just change the code |
justinmclean
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, when a metalake is created without specifying the metalake argument, the message "Cannot parse a null or empty identifier" is displayed. This message is unclear and lacks helpful guidance for the user. Update the message to: "! metalake is not defined" to make it more user-friendly and informative.
Why are the changes needed?
Fix: #5825
Does this PR introduce any user-facing change?
NO
How was this patch tested?