Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6409] fix(client-python): Change to use GenericFileset for the return value of fileset catalog #6410

Merged
merged 1 commit into from
Feb 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clients/client-python/gravitino/client/fileset_catalog.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def create_fileset(
fileset_resp = FilesetResponse.from_json(resp.body, infer_missing=True)
fileset_resp.validate()

return fileset_resp.fileset()
return GenericFileset(fileset_resp.fileset(), self.rest_client, full_namespace)

def alter_fileset(self, ident: NameIdentifier, *changes) -> Fileset:
"""Update a fileset metadata in the catalog.
Expand All @@ -187,7 +187,7 @@ def alter_fileset(self, ident: NameIdentifier, *changes) -> Fileset:
ident: A fileset identifier, which should be "schema.fileset" format.
changes: The changes to apply to the fileset.
Args:
Raises:
IllegalArgumentException If the changes are invalid.
NoSuchFilesetException If the fileset does not exist.
Expand All @@ -212,7 +212,7 @@ def alter_fileset(self, ident: NameIdentifier, *changes) -> Fileset:
fileset_resp = FilesetResponse.from_json(resp.body, infer_missing=True)
fileset_resp.validate()

return fileset_resp.fileset()
return GenericFileset(fileset_resp.fileset(), self.rest_client, full_namespace)

def drop_fileset(self, ident: NameIdentifier) -> bool:
"""Drop a fileset from the catalog.
Expand Down