[#6238] improvement(storage): Improve get role performance when roles is bound to many metadata. #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In xiaomi company, we find when roles is bounded to many securable objects, then get role is very slow, so we try so solve get role function. |
FourFriends
force-pushed
the
feat-0214-role
branch
from
c811185 to
1860a7a
Compare
FourFriends
changed the title
jerqi
reviewed
Feb 14, 2025
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/gravitino/storage/relational/service/TestRoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Show resolved
Hide resolved
jerqi
changed the title
yuqi1129
reviewed
Feb 14, 2025
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Show resolved
Hide resolved
FourFriends
force-pushed
the
feat-0214-role
branch
from
1860a7a to
0dc985e
Compare
jerqi
reviewed
Feb 14, 2025
.../org/apache/gravitino/storage/relational/mapper/provider/base/SchemaMetaBaseSQLProvider.java
Outdated
Show resolved
Hide resolved
FourFriends
force-pushed
the
feat-0214-role
branch
from
0dc985e to
a638ad3
Compare
jerqi
reviewed
Feb 14, 2025
core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java
Outdated
Show resolved
Hide resolved
FourFriends
force-pushed
the
feat-0214-role
branch
from
a638ad3 to
5f39afe
Compare
FourFriends
force-pushed
the
feat-0214-role
branch
from
5f39afe to
7c6803d
Compare
|
@yuqi1129 Do U have any other suggestion? |
No, it looks good to me. |
|
Merged. @yuqi1129 Thanks for your review. @FourFriends. thanks for your first contribution. It's a great start. Welcome to join the Gravitino community and enjoy your trip of open source. |
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Feb 19, 2025
… roles is bound to many metadata. (apache#6455) ### What changes were proposed in this pull request? fix issue apache#6238 improve performance when a single role is bound to many metadata. ### Why are the changes needed? Use batch queries when getting role securable object full names instead of loop queries to get each securable object full name. Fix: apache#6238 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests and integration tests have all passed, this feature has been running internally at Xiaomi for two weeks. Co-authored-by: luoxin5 <[email protected]>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Feb 19, 2025
… roles is bound to many metadata. (apache#6455) ### What changes were proposed in this pull request? fix issue apache#6238 improve performance when a single role is bound to many metadata. ### Why are the changes needed? Use batch queries when getting role securable object full names instead of loop queries to get each securable object full name. Fix: apache#6238 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests and integration tests have all passed, this feature has been running internally at Xiaomi for two weeks. Co-authored-by: luoxin5 <[email protected]>
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Mar 2, 2025
… roles is bound to many metadata. (apache#6455) ### What changes were proposed in this pull request? fix issue apache#6238 improve performance when a single role is bound to many metadata. ### Why are the changes needed? Use batch queries when getting role securable object full names instead of loop queries to get each securable object full name. Fix: apache#6238 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests and integration tests have all passed, this feature has been running internally at Xiaomi for two weeks. Co-authored-by: luoxin5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix issue #6238
improve performance when a single role is bound to many metadata.
Why are the changes needed?
Use batch queries when getting role securable object full names instead of loop queries to get each securable object full name.
Fix: #6238
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests and integration tests have all passed, this feature has been running internally at Xiaomi for two weeks.