[#6481] improve(CLI): Refactor table output format #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor table output format, make it easier to test and scale.
Rename the constant.
|
Hi @justinmclean could you please review this PR when you have time? I’d really appreciate your feedback. |
tengqm
reviewed
Feb 20, 2025
clients/cli/src/main/java/org/apache/gravitino/cli/CommandContext.java
Outdated
Show resolved
Hide resolved
|
In the plain form test, why does the output have #s in front of each line? |
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/BaseOutputFormat.java
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/BaseOutputFormat.java
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public TableFormat(CommandContext context) { | ||
| super(context); | ||
| // TODO: add other options for TableFormat |
There was a problem hiding this comment.
Like sort or limit？
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/TableFormat.java
Outdated
Show resolved
Hide resolved
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/TableFormat.java
Outdated
Show resolved
Hide resolved
fix some code.
I manually added the # sign to distinguish between commands and results. |
|
@justinmclean I’ve finished updating the code. Please take a look at the PR again when you have time. |
|
@justinmclean should we add table, schema list\detail command Table output in this pr? or create a new one? |
|
I would do it in a new PR - there are enough changes here. |
justinmclean
approved these changes
Feb 21, 2025
Abyss-lord
added a commit
to Abyss-lord/gravitino
that referenced
this pull request
Mar 2, 2025
### What changes were proposed in this pull request? Refactor table output format, make it easier to test and scale. ### Why are the changes needed? Fix: apache#6481 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? table format test ```bash gcli metalake list -i --output table +-------------------+ | Metalake | +-------------------+ | demo | | cli_demo | | demo_metalake | | test_cli_metalake | | tyy | | demo3 | +-------------------+ gcli metalake details -i --output table -m demo_metalake +---------------+-------------+ | Metalake | Comment | +---------------+-------------+ | demo_metalake | new comment | +---------------+-------------+ gcli catalog list -i --output table -m demo_metalake +-------------------+ | Catalog | +-------------------+ | File | | Hive_catalog | | Iceberg_catalog | | Mysql_catalog | | Test_hive_catalog | +-------------------+ gcli catalog details --name Hive_catalog -i --output table -m demo_metalake +--------------+------------+----------+-------------+ | Catalog | Type | Provider | Comment | +--------------+------------+----------+-------------+ | Hive_catalog | RELATIONAL | hive | new comment | +--------------+------------+----------+-------------+ ``` plainformat test ```bash gcli metalake list -i # demo # cli_demo # demo_metalake # test_cli_metalake # demo3 gcli metalake details -i -m demo_metalake # demo_metalake, new comment gcli catalog list -i -m demo_metalake # File # Hive_catalog # Iceberg_catalog # Mysql_catalog # Test_hive_catalog gcli catalog details --name Hive_catalog -i -m demo_metalake # Hive_catalog, RELATIONAL, hive, new comment ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor table output format, make it easier to test and scale.
Why are the changes needed?
Fix: #6481
Does this PR introduce any user-facing change?
No
How was this patch tested?
table format test
plainformat test