Trivial tweak: avoid unnecessary checks

apache · Jan 10, 2025 · de71720 · de71720
1 parent 2ddb72c
commit de71720
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/groovy/lang/MetaClassImpl.java b/src/main/java/groovy/lang/MetaClassImpl.java
@@ -2517,8 +2517,8 @@ private void applyStrayPropertyMethods(CachedClass source, Map<String, MetaPrope
             boolean isBooleanGetter = methodName.startsWith("is");
             if (methodNameLength < (isBooleanGetter ? 3 : 4)) continue;
 
-            boolean isGetter = methodName.startsWith("get") || isBooleanGetter;
-            boolean isSetter = methodName.startsWith("set");
+            boolean isGetter = isBooleanGetter || methodName.startsWith("get");
+            boolean isSetter = !isGetter       && methodName.startsWith("set");
             if (!isGetter && !isSetter) continue;
 
             Object propertyMethods = filterPropertyMethod(isThis ? e.methods : e.methodsForSuper, isGetter, isBooleanGetter);