fix setrep bug

apache · Dec 6, 2022 · f640886 · f640886
1 parent 761aaa3
commit f640886
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...f/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java b/...f/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java
@@ -411,9 +411,8 @@ public boolean setReplication(String src, short replication)
     RemoteMethod method = new RemoteMethod("setReplication",
         new Class<?>[] {String.class, short.class}, new RemoteParam(),
         replication);
-    if (rpcServer.isInvokeConcurrent(src)) {
-      return !rpcClient.invokeConcurrent(locations, method, Boolean.class)
-          .containsValue(false);
+    if (rpcServer.isPathAll(src)) {
+      return rpcClient.invokeAll(locations, method);
     } else {
       return rpcClient.invokeSequential(locations, method, Boolean.class,
           Boolean.TRUE);

diff --git a/.../src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAllResolver.java b/.../src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterAllResolver.java
@@ -203,6 +203,11 @@ private void testAll(final String path) throws Exception {
     assertEquals("Truncate file  fails", 10,
       routerFs.getFileStatus(testTruncateFilePath).getLen());
 
+    // Test setReplication
+    assertTrue(routerFs.setReplication(testTruncateFilePath,(short) 2));
+    assertEquals("SetReplication file fails", 2,
+      routerFs.getFileStatus(testTruncateFilePath).getReplication());
+
     // Removing a directory should remove it from every subcluster
     routerFs.delete(new Path(path + "/dir2/dir22/dir220"), true);
     assertDirsEverywhere(path, 8);