HADOOP-13694. Add support for AES-192 in OpensslCipher. #135
+258
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QwertyManiac
commented
Oct 6, 2016
QwertyManiac
commented
- Adds equivalent support for 192-bit AES/CTR/NoPadding codec in the OpensslCipher
- Adds test-cases to cover 192-bit (24-bytes) and 256-bit (32-bytes) keys to both JCE and OpenSSL crypto tests
- Enhances the error message when an invalid Key or IV size is passed into OpensslCipher
QwertyManiac
force-pushed
the
HDFS-9878
branch
from
4e08baf to
952bf94
Compare
QwertyManiac
force-pushed
the
HDFS-9878
branch
from
952bf94 to
82cdd6a
Compare
QwertyManiac
changed the title
karth295
suggested changes
Nov 14, 2016
| if (asprintf(&keyLenErrMsg, "Invalid key length: %d bytes", jKeyLen) < 0) { | ||
| THROW(env, "java/lang/IllegalArgumentException", "Invalid key length"); | ||
| } else { | ||
| THROW(env, "java/lang/IllegalArgumentException", keyLenErrMsg); |
There was a problem hiding this comment.
Thank you for the review! Done in the new commit.
| if (asprintf(&ivLenErrMsg, "Invalid iv length: %d bytes", jIvLen) < 0) { | ||
| THROW(env, "java/lang/IllegalArgumentException", "Invalid iv length."); | ||
| } else { | ||
| THROW(env, "java/lang/IllegalArgumentException", ivLenErrMsg); |
There was a problem hiding this comment.
Same here -- you need to free ivLenErrMsg
There was a problem hiding this comment.
Thank you for the review! Done in the new commit.
- Added missing free calls to the messages generated, after the throw
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Clean up the LocalApplicationRunner based on the further feedback. The changes include the following: 1. Remove the processorId from the JobCoordinatorFactory/JobCoordinator interfaces 2. LocalApplicationRunner.run() is non-blocking. Add LocalApplicationRunner.waitForFinish() for blocking for completion 3. Remove the config for CooridnatorServiceFactory, and now the CoordinatorService is created based on the type of JobCoordinator. 4. Clean up the StreamProcessor life cycle listener logic inside LocalApplicationRunner. Author: Xinyu Liu <[email protected]> Reviewers: Navina Ramesh <[email protected]> Closes apache#135 from xinyuiscool/SAMZA-1222
This was referenced Nov 19, 2024
This was referenced Nov 26, 2024
This was referenced Dec 3, 2024
This was referenced Dec 10, 2024
This was referenced Dec 20, 2024
This was referenced Dec 26, 2024
Closed
This was referenced Jan 4, 2025
This was referenced Jan 16, 2025
HADOOP-19280. [ABFS] Initialize client timer only if metric collection is enabled (branch-3.4)
#7307
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.