Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hadoop-18520. Backport HADOOP-18427 and HADOOP-18452 to branch-3.3 #5118

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

melissayou
Copy link
Contributor

Description of PR

As part of HADOOP-18518, this is the 3rd PR to fix deprecation of EnsurePath. in new Curator. It's a clean cherry pick from HADOOP-18427 and HADOOP-18452.

How was this patch tested?

mvn clean install -Pdist -Dtar -DskipTests -Dmaven.javadoc.skip builds success

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 40m 11s branch-3.3 passed
+1 💚 compile 19m 15s branch-3.3 passed
+1 💚 checkstyle 1m 13s branch-3.3 passed
+1 💚 mvnsite 1m 49s branch-3.3 passed
+1 💚 javadoc 1m 7s branch-3.3 passed
+1 💚 spotbugs 2m 59s branch-3.3 passed
+1 💚 shadedclient 28m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 8s the patch passed
+1 💚 compile 18m 21s the patch passed
+1 💚 javac 18m 21s root generated 0 new + 1867 unchanged - 3 fixed = 1867 total (was 1870)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 4s the patch passed
+1 💚 mvnsite 1m 47s the patch passed
+1 💚 javadoc 0m 54s the patch passed
+1 💚 spotbugs 2m 55s the patch passed
+1 💚 shadedclient 28m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 55s hadoop-common in the patch passed.
+1 💚 asflicense 1m 10s The patch does not generate ASF License warnings.
178m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/artifact/out/Dockerfile
GITHUB PR #5118
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 81a6ffc159e7 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / d1551e9
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/testReport/
Max. process+thread count 1253 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989
Copy link
Contributor

@melissayou Thanks for your contribution, LGTM.

@virajith virajith changed the title [Hadoop 18520]Backport HADOOP-18427 and HADOOP-18452 to branch-3.3 Hadoop-18520. Backport HADOOP-18427 and HADOOP-18452 to branch-3.3 Nov 8, 2022
@virajith
Copy link
Contributor

virajith commented Nov 8, 2022

Thanks for backporting these changes @melissayou! Changes look good.

@virajith virajith merged commit d33ee67 into apache:branch-3.3 Nov 8, 2022
NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
…pache#5118) (apache#29)

* HADOOP-18427. Improve ZKDelegationTokenSecretManager#startThead With recommended methods. (apache#4812)

* HADOOP-18452. Fix TestKMS#testKMSHAZooKeeperDelegationToken Failed By Hadoop-18427. (apache#4885)

Co-authored-by: slfan1989 <[email protected]>
Co-authored-by: Melissa You <[email protected]>

Co-authored-by: slfan1989 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants