HDFS-17298. Fix NPE in DataNode.handleBadBlock and BlockSender

[haiyang1987]

Description of PR

https://issues.apache.org/jira/browse/HDFS-17298

There are some NPE issues on the DataNode side of our online environment.

The detailed exception information is

2023-12-20 13:58:25,449 ERROR datanode.DataNode (DataXceiver.java:run(330)) [DataXceiver for client DFSClient_NONMAPREDUCE_xxx at /xxx:41452 [Sending block BP-xxx:blk_xxx]] - xxx:50010:DataXceiver error processing READ_BLOCK operation  src: /xxx:41452 dst: /xxx:50010
java.lang.NullPointerException
        at org.apache.hadoop.hdfs.server.datanode.BlockSender.<init>(BlockSender.java:301)
        at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:607)
        at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opReadBlock(Receiver.java:152)
        at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:104)
        at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:298)
        at java.lang.Thread.run(Thread.java:748)

NPE Code logic:

if (!fromScanner && blockScanner.isEnabled()) {
  // data.getVolume(block) is null
  blockScanner.markSuspectBlock(data.getVolume(block).getStorageID(),
      block);
} 

2023-12-20 13:52:18,844 ERROR datanode.DataNode (DataXceiver.java:run(330)) [DataXceiver for client /xxx:61052 [Copying block BP-xxx:blk_xxx]] - xxx:50010:DataXceiver error processing COPY_BLOCK operation  src: /xxx:61052 dst: /xxx:50010
java.lang.NullPointerException
        at org.apache.hadoop.hdfs.server.datanode.DataNode.handleBadBlock(DataNode.java:4045)
        at org.apache.hadoop.hdfs.server.datanode.DataXceiver.copyBlock(DataXceiver.java:1163)
        at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opCopyBlock(Receiver.java:291)
        at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:113)
        at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:298)
        at java.lang.Thread.run(Thread.java:748)

NPE Code logic:

// Obtain a reference before reading data
volumeRef = datanode.data.getVolume(block).obtainReference(); //datanode.data.getVolume(block) is null  

We need to fix it.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	46m 19s		trunk passed
+1 💚	compile	1m 23s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 14s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 13s		trunk passed
+1 💚	mvnsite	1m 23s		trunk passed
+1 💚	javadoc	1m 9s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 38s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	3m 20s		trunk passed
+1 💚	shadedclient	41m 11s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 11s		the patch passed
+1 💚	compile	1m 16s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 16s		the patch passed
+1 💚	compile	1m 9s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	1m 9s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		the patch passed
+1 💚	mvnsite	1m 16s		the patch passed
+1 💚	javadoc	0m 56s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 30s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	3m 22s		the patch passed
+1 💚	shadedclient	40m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	248m 15s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		400m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6374/1/artifact/out/Dockerfile
GITHUB PR	#6374
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 034b1ce6d5d0 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / b68523c
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6374/1/testReport/
Max. process+thread count	2269 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6374/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[haiyang1987]

Hi @ayushtkn @Hexiaoqiao @ZanderXu @tasanuma @zhangshuyan0 Could you please help me review this pr when you have free time ? Thank you very much.

[tasanuma]

LGTM.

[tasanuma]

Merged. Thanks for your PR, @haiyang1987!

[haiyang1987]

Thanks @tasanuma for you review and merge!