Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]:Add English version of documentation for Kafka Consumer Detail #2953

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Rancho-7
Copy link
Contributor

@Rancho-7 Rancho-7 commented Jan 6, 2025

What's changed?

Add English version of documentation for recently added Kafka consumer metrics,

999

which previously only had a Chinese version.

000

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Jan 6, 2025
yuluo-yx
yuluo-yx previously approved these changes Jan 6, 2025
Copy link
Member

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28
Copy link
Contributor

tomsun28 commented Jan 6, 2025

hi, there has markdown check error, please help to fix.

Error: home/docs/help/kafka_client.md:54:33 MD010/no-hard-tabs Hard tabs [Column: 33] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md010.md
Error: home/docs/help/kafka_client.md:57:59 MD047/single-trailing-newline Files should end with a single newline character https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md047.md
Error: Failed with exit code: 1

@Rancho-7
Copy link
Contributor Author

Rancho-7 commented Jan 7, 2025

hi, there has markdown check error, please help to fix.

Hi Tom,thanks,I have fixed it.

@tomsun28 tomsun28 merged commit d8dabe2 into apache:master Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants