fix clippy

apache · Dec 26, 2024 · 9817e45 · 9817e45
1 parent dd089bd
commit 9817e45
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/metric_engine/src/read.rs b/src/metric_engine/src/read.rs
@@ -51,7 +51,6 @@ use datafusion::{
 use futures::{Stream, StreamExt};
 use itertools::Itertools;
 use parquet::arrow::async_reader::ParquetObjectReader;
-use tracing::debug;
 
 use crate::{
     compare_primitive_columns,
@@ -250,11 +249,11 @@ impl MergeStream {
     }
 
     fn maybe_remove_builtin_columns(&self, batch: &mut RecordBatch) {
-        debug!(batch = ?batch, keep=self.keep_builtin, "maybe_remove_builtin_columns");
         if self.keep_builtin {
             return;
         }
 
+        // builtin columns are always at the end.
         for _ in 0..BUILTIN_COLUMN_NUM {
             batch.remove_column(batch.num_columns() - 1);
         }

diff --git a/src/metric_engine/src/types.rs b/src/metric_engine/src/types.rs
@@ -288,7 +288,7 @@ mod tests {
         .unwrap();
         assert_eq!(new_batch, expected_batch);
 
-        let mut testcases = vec![
+        let mut testcases = [
             (None, None),
             (Some(vec![]), Some(vec![0, 1, 3, 4])),
             (Some(vec![1]), Some(vec![1, 0, 3, 4])),