fix: fix kafka wal logs deletion and recovery logic #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
refactor-kafka-wal-delete-and-recover
branch
from
d00c5a8 to
e42cf52
Compare
chunshao90
reviewed
Jul 5, 2023
Rachelint
changed the title
ShiKaiWi
reviewed
Jul 5, 2023
Rachelint
added a commit
to Rachelint/ceresdb
that referenced
this pull request
Jul 11, 2023
## Rationale In the old kafka logs deletion and recovery logic, some conercases leading to logs can never be cleaned up. ## Detailed Changes - Fix the logs deletion logic. - Fix recovery logic. ## Test Plan Test manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In the old kafka logs deletion and recovery logic, some conercases leading to logs can never be cleaned up.
Detailed Changes
Test Plan
Test manually.