Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: out of range error in module ObjectStore base on OBKV #1089

Merged
merged 6 commits into from
Jul 21, 2023
Merged

fix: out of range error in module ObjectStore base on OBKV #1089

merged 6 commits into from
Jul 21, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Rationale

In current version, there are two bugs in module ObjectStore based on OBKV.

  • Out of range error occurs when calling method get_range
  • Save meta info error when putting an existing file.

Detailed Changes

  • Fix these bugs
  • Add some unit tests

Test Plan

  • Test by unit tests

@MichaelLeeHZ MichaelLeeHZ marked this pull request as ready for review July 20, 2023 06:23
jiacai2050
jiacai2050 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit fa3bb32 into apache:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelLeeHZ @jiacai2050 @ShiKaiWi