Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid panic when the file is corrupted in disk cache #1130

Merged
merged 9 commits into from
Aug 8, 2023
Merged

fix: avoid panic when the file is corrupted in disk cache #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e67da1
fix: avoid panic when the file is corrupted in disk cache
ShiKaiWi Aug 3, 2023
1fd286e
refactor: redesign the logic of disk cache
ShiKaiWi Aug 4, 2023
a375510
refactor: make it compatible
ShiKaiWi Aug 4, 2023
145fbf5
chore: object store metrics only for real object store
ShiKaiWi Aug 4, 2023
301f7f3
fix: invalid default bits for size cache
ShiKaiWi Aug 7, 2023
07106b8
fix: use write_all instead of write method
ShiKaiWi Aug 7, 2023
3670f22
fix: unit test
ShiKaiWi Aug 7, 2023
010bd71
fix: address CR
ShiKaiWi Aug 8, 2023
ede7c93
chore: avoid big `if` block
ShiKaiWi Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions analytic_engine/src/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,12 +519,18 @@ fn open_storage(
}
};

store = Arc::new(StoreWithMetrics::new(
store,
engine_runtimes.io_runtime.clone(),
));

if opts.disk_cache_capacity.as_byte() > 0 {
let path = Path::new(&opts.disk_cache_dir).join(DISK_CACHE_DIR_NAME);
tokio::fs::create_dir_all(&path).await.context(CreateDir {
path: path.to_string_lossy().into_owned(),
})?;

// TODO: Consider the readonly cache.
store = Arc::new(
DiskCacheStore::try_new(
path.to_string_lossy().into_owned(),
Expand All @@ -538,11 +544,6 @@ fn open_storage(
) as _;
}

store = Arc::new(StoreWithMetrics::new(
store,
engine_runtimes.io_runtime.clone(),
));

if opts.mem_cache_capacity.as_byte() > 0 {
let mem_cache = Arc::new(
MemCache::try_new(
Expand Down
Loading