feat: support re-acquire shard lock in a fast way #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
reviewed
Oct 10, 2023
Rachelint
reviewed
Oct 10, 2023
Rachelint
reviewed
Oct 10, 2023
Rachelint
reviewed
Oct 10, 2023
jiacai2050
reviewed
Oct 10, 2023
ShiKaiWi
force-pushed
the
feat-fast-acquire-shard-lock
branch
from
f81162b to
4b956ba
Compare
jiacai2050
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently, a restarted ceresdb-server must wait for the previous lock lease to expire before acquiring the new shard locks, leading to long failover time.
Detailed Changes
Support fast reacquire the shard lock by reusing the previous lock lease.
Test Plan
Manually test this feature.