feat: impl basic auth #1531
Merged
feat: impl basic auth #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
May 13, 2024
src/proxy/src/auth/mod.rs
Outdated
| pub struct AuthBase; | ||
|
|
||
| impl Auth for AuthBase { | ||
| fn load_credential(&mut self) -> Result<()> { |
There was a problem hiding this comment.
Remove default implementation.
src/proxy/src/auth/mod.rs
Outdated
| } | ||
|
|
||
| #[derive(Default)] | ||
| pub struct AuthBase; |
src/proxy/src/grpc/prom_query.rs
Outdated
| @@ -81,6 +81,21 @@ impl Proxy { | |||
| msg: "Missing context", | |||
| code: StatusCode::BAD_REQUEST, | |||
| })?; | |||
|
|
|||
| // Check if the tenant is authorized to access the database. | |||
| if !self | |||
There was a problem hiding this comment.
Use interceptor to do auth check for gRPC
https://github.com/hyperium/tonic/blob/master/examples/src/interceptor/server.rs
For HTTP, see https://stackoverflow.com/questions/54988438/how-to-check-the-authorization-header-using-warp
src/proxy/src/auth/mod.rs
Outdated
| #[derive(Debug, Clone, Deserialize, Serialize, Default)] | ||
| pub struct Config { | ||
| pub enable: bool, | ||
| pub auth_type: String, |
There was a problem hiding this comment.
Define this with an Enum.
src/proxy/src/auth/mod.rs
Outdated
| pub type AuthRef = Arc<Mutex<dyn Auth>>; | ||
|
|
||
| /// Header of tenant name | ||
| pub const TENANT_HEADER: &str = "x-horaedb-access-tenant"; |
There was a problem hiding this comment.
Basic authorization use authorization header, we should avoid those custom headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #929
Detailed Changes
Test Plan
Add this to config,
/tmp/auth.csvhas this formatusername,password, one user one line.