Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename as_bytes to as_byte in ReadableSize (#428) #766

Closed
wants to merge 0 commits into from
Closed

fix: rename as_bytes to as_byte in ReadableSize (#428) #766

wants to merge 0 commits into from

Conversation

zouxiang1993
Copy link
Contributor

@zouxiang1993 zouxiang1993 commented Mar 25, 2023

Which issue does this PR close?

Closes #428

Rationale for this change

Refer to #428

What changes are included in this PR?

  • Rename the method as_bytes of ReadableSize to as_byte.

Are there any user-facing changes?

None.

How does this change test

Existing tests.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2023

CLA assistant check
All committers have signed the CLA.

@zouxiang1993 zouxiang1993 marked this pull request as ready for review March 25, 2023 08:40
@ShiKaiWi
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

zouxiang1993 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zouxiang1993 Would you like to sign the CLA: Contributor License Agreement?

@codecov-commenter
Copy link

Codecov Report

Merging #766 (d031e1c) into main (8a9635e) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

❗ Current head d031e1c differs from pull request most recent head 2c1a69f. Consider uploading reports for the commit 2c1a69f to get more accurate results

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   68.34%   68.32%   -0.02%     
==========================================
  Files         296      296              
  Lines       46315    46315              
==========================================
- Hits        31656    31647       -9     
- Misses      14659    14668       +9     
Impacted Files Coverage Δ
server/src/server.rs 0.00% <0.00%> (ø)
analytic_engine/src/setup.rs 56.00% <40.00%> (ø)
analytic_engine/src/compaction/picker.rs 84.44% <50.00%> (ø)
analytic_engine/src/compaction/scheduler.rs 74.41% <100.00%> (ø)
analytic_engine/src/instance/open.rs 80.74% <100.00%> (ø)
common_util/src/config.rs 87.02% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zouxiang1993
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
zouxiang1993 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zouxiang1993 Would you like to sign the CLA: Contributor License Agreement?

I have already signed and got a message "You have agreed to the CLA for CeresDB/ceresdb Version: 2022-09-13" in CLA assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad name in ReadableSize
4 participants