Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure code coverage reporting #6

Closed
xushiyan opened this issue May 4, 2024 · 0 comments · Fixed by #15, #17 or #20
Closed

Configure code coverage reporting #6

xushiyan opened this issue May 4, 2024 · 0 comments · Fixed by #15, #17 or #20
Assignees
Labels
dev-x Dev experience: code format, dev tooling, project management
Milestone

Comments

@xushiyan
Copy link
Member

xushiyan commented May 4, 2024

Update 2024-05-09

Got codecov token available and this is fixed in #20

Update 2024-05-06

Sonar cloud does not support

  • rust lang for code coverage reporting despite community asks over a few years
  • asf sonarcloud token is not usable on forked repo PRs, meaning it's not feasible to report coverage in PRs which come from fork almost all the time
  • community maintained tool cargo-sonar does not support coverage reporting either. The supported tools like clippy, audit, etc should be enforced on PRs, instead of post-reporting from main branch. Hence cargo-sonar not a choice here.

2 possible solutions

Update 2024-05-05

See description in #17 (comment)

@xushiyan xushiyan added this to the release-0.1.0 milestone May 4, 2024
@xushiyan xushiyan added the dev-x Dev experience: code format, dev tooling, project management label May 4, 2024
xushiyan added a commit that referenced this issue May 6, 2024
@xushiyan xushiyan self-assigned this May 6, 2024
@xushiyan xushiyan linked a pull request May 6, 2024 that will close this issue
@xushiyan xushiyan reopened this May 6, 2024
@xushiyan xushiyan reopened this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-x Dev experience: code format, dev tooling, project management
Projects
None yet
1 participant