Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support loading hudi global configs #118

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

zzhpro
Copy link
Contributor

@zzhpro zzhpro commented Aug 21, 2024

Description

Load hudi-defaults.conf from HUDI_CONF_DIR when creating table instance , for #111 .

How are the changes test-covered

  • Automated tests: I have added a unit test for this feature

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (8209599) to head (42297eb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/mod.rs 91.66% 2 Missing ⚠️
crates/core/src/storage/utils.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   87.60%   87.77%   +0.16%     
==========================================
  Files          14       14              
  Lines         702      728      +26     
==========================================
+ Hits          615      639      +24     
- Misses         87       89       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan
Copy link
Member

@zzhpro thanks. i've made some refactoring based on your version.

@xushiyan xushiyan added this to the release-0.2.0 milestone Sep 10, 2024
@xushiyan xushiyan linked an issue Sep 10, 2024 that may be closed by this pull request
@xushiyan xushiyan merged commit 01ef2fc into apache:main Sep 10, 2024
10 checks passed
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating table instances should also load hudi-defaults.conf
2 participants