test: obtain fixture artifact path programmatically #137
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 14 14
Lines 728 728
=======================================
Hits 639 639
Misses 89 89 ☔ View full report in Codecov by Sentry. |
prabodh1194
changed the title
prabodh1194
force-pushed
the
make_pytest_ide_friendly
branch
from
2d72224 to
681d6f8
Compare
prabodh1194
changed the title
prabodh1194
force-pushed
the
make_pytest_ide_friendly
branch
from
681d6f8 to
463dcdc
Compare
prabodh1194
force-pushed
the
make_pytest_ide_friendly
branch
from
463dcdc to
f5f50ed
Compare
|
@KnightChess should I go ahead & add a pre-commit hook for |
|
fair enough. thank you. |
There was a problem hiding this comment.
Thanks for raising this. 1 comment to address on the OS compatibility.
Building on top of this, we actually want to use crates/tests the centralized place for all testing tables. We already have enums for providing the pre-generated table there. In python codebase, we just need to use pyo3 to bind the crate over so we don't need to maintain separate testing data and module in python.
|
|
||
| def _extract_testing_table(zip_file_path, target_path) -> str: | ||
|
|
||
| def _extract_testing_table(zip_file_path: Path, target_path: PosixPath) -> str: |
There was a problem hiding this comment.
PosixPath restricted this from running on windows? we'll need to support test and build on windows too
There was a problem hiding this comment.
Oh. Got it. Lemme figure out how to test this
|
@prabodh1194 I created #141 as an extended work for this. If you're interested, feel free to pick it up. |
|
thanks. lemme try. |
We will cover this PR's intent in #141 so we can close this |
Description
I am setting up my dev environment in RustRover IDE and wanted to run the pytest from the IDE's command runner. However, the default setup was giving me some issue related to the
.ziptable artifact. To work around this, I have colocated a python script with the artifact so that I can deterministically get the correct path of the corresponding zip file.How are the changes test-covered