Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve TableBuilder API for taking single option #171

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

xushiyan
Copy link
Member

Description

Support taking single option key value pair using TableBuilder API.

Follow up for #163

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change python Related to Python codebase rust Related to Rust codebase labels Oct 14, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (c8862e4) to head (da50983).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/builder.rs 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   90.35%   90.53%   +0.17%     
==========================================
  Files          19       19              
  Lines         933      961      +28     
==========================================
+ Hits          843      870      +27     
- Misses         90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan changed the title refactor: improve builder API for taking single option refactor: improve TableBuilder API for taking single option Oct 14, 2024
@xushiyan xushiyan merged commit 10c55c1 into apache:main Oct 14, 2024
11 checks passed
@xushiyan xushiyan deleted the add-table-builder-api branch October 14, 2024 05:59
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python codebase refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant