Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve api to get file slices splits #185

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

xushiyan
Copy link
Member

Description

Rename api split_file_slices() to get_file_slices_splits() and handle empty table case.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added the bug Something isn't working label Nov 20, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (bf5c6dd) to head (14219b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   90.81%   90.92%   +0.11%     
==========================================
  Files          20       20              
  Lines         958      959       +1     
==========================================
+ Hits          870      872       +2     
+ Misses         88       87       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@xushiyan xushiyan force-pushed the fix-file-slices-splits-api branch from d09d332 to 14219b9 Compare November 20, 2024 06:50
@xushiyan xushiyan merged commit 0effb24 into apache:main Nov 20, 2024
9 checks passed
@xushiyan xushiyan deleted the fix-file-slices-splits-api branch November 20, 2024 07:05
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant