Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement incremental query for COW tables #236

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jan 6, 2025

Description

For performing incremental queries (latest-state mode), added table APIs

# rust
read_incremental_records(&self, start_timestamp: &str, end_timestamp: Option<&str>)

# python
read_incremental_records(self, start_timestamp: str, end_timestamp: Optional[str])

Closes #9

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 6, 2025
@xushiyan xushiyan added python Related to Python codebase rust Related to Rust codebase labels Jan 6, 2025
@xushiyan xushiyan marked this pull request as ready for review January 7, 2025 19:25
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (d04b9ab) to head (2e252a0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/storage/mod.rs 28.57% 5 Missing ⚠️
crates/core/src/table/mod.rs 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   92.03%   92.78%   +0.74%     
==========================================
  Files          26       27       +1     
  Lines        1268     1344      +76     
==========================================
+ Hits         1167     1247      +80     
+ Misses        101       97       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit a396f6c into apache:main Jan 8, 2025
10 checks passed
@xushiyan xushiyan deleted the incr-query branch January 8, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature python Related to Python codebase rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CoW incremental query
1 participant