-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-7338] Upgrade Jetty, HBase, and pulsar-client #10223
Conversation
hudi-common/pom.xml
Outdated
<exclusion> | ||
<groupId>org.apache.hbase.thirdparty</groupId> | ||
<artifactId>hbase-shaded-jetty</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, encountered some ClassNotFoundException
: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=21260&view=logs&j=7601efb9-4019-552e-11ba-eb31b66593b2&t=9688f101-287d-53f4-2a80-87202516f5d0&l=5086
@hudi-bot run azure |
hudi-common/pom.xml
Outdated
<exclusion> | ||
<groupId>org.apache.hbase.thirdparty</groupId> | ||
<artifactId>hbase-shaded-jetty</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @yihua for the review~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danny0405, thanks for helping out but this PR is still WIP.
Hudi uses hbase-shaded-netty
from hbase thirdparty package and the netty is outdated there. Even the latest OSS hbase thirdparty won't have the fixed netty version(https://github.com/apache/hbase-thirdparty/blob/master/pom.xml#L137) (the fixed netty version is 4.1.100).
I'm still trying to figure out how to exclude netty from that shaded package. But would be happy to hear if you have any idea
@hudi-bot run azure |
536833e
to
4827a8d
Compare
157fb0e
to
d197ce8
Compare
Hi @danny0405, Could you help take a look again? Thanks! |
Co-authored-by: Shawn Chang <[email protected]>
Change Logs
Bump version of Jetty ,HBase ,and pulsar-client
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
N/A
Contributor's checklist