Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Disable org.apache.hudi.TestHoodieSparkSqlWriter#testInsertDatasetWithTimelineTimezoneUTC #10449

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jonvex
Copy link
Contributor

@jonvex jonvex commented Jan 5, 2024

Change Logs

This test was causing following tests to get stuck. Something to do with the lock provider maybe. After investigating for a couple hours I wasn't able to discover anything. Created HUDI-7275 to track.

Impact

Possibly the cause of some CI OOMs

Risk level (write none, low medium or high below)

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link

hudi-bot commented Jan 6, 2024

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit b54381f into apache:master Jan 8, 2024
31 checks passed
VitoMakarevich pushed a commit to VitoMakarevich/hudi that referenced this pull request Jan 13, 2024
Co-authored-by: Jonathan Vexler <=>
VitoMakarevich pushed a commit to VitoMakarevich/hudi that referenced this pull request Jan 13, 2024
Co-authored-by: Jonathan Vexler <=>
@geserdugarov
Copy link
Contributor

geserdugarov commented Jan 18, 2024

@jonvex @nsivabalan
I also saw this problem, but couldn't figure out how to quickly fix it.

The problem is that we have static AtomicReference lastInstantTime in HoodieInstantTimeGenerator.

If this test testInsertDatasetWithTimelineTimezoneUTC is run the first, then it would be passed ok. Otherwise, if any other test in the test class would initialize HoodieInstantTimeGenerator, then the value for lastInstantTime would stay in the heap and you couldn't do anything to clear it, for instance, in @AfterEach processing.

yihua pushed a commit that referenced this pull request Feb 27, 2024
Co-authored-by: Jonathan Vexler <=>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants