[HUDI-7296] Reduce CI Time by Minimizing Duplicate Code Coverage in Tests #10492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2024 15:35
|
@jonvex, when is "fullTest" set to "true"? |
| } | ||
| } | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
```
String tableType = COW, MOR
Boolean shouldCluster = true
Boolean shouldCompact = true
Boolean rowWriterEnable = true
Boolean addFilegroups = true
Boolean multiLogFiles = true
Boolean useKafkaSource= false, true
Boolean allowNullForDeletedCols=false,true
```
I wonder if we just do sth like this. with new file groups, multiple log files, alongside cluster and compaction, should be the more complex (superset) scenario. no?
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| b.add(Arguments.of("COPY_ON_WRITE", true, true, true, true, true)); |
There was a problem hiding this comment.
similar. could we just come up with the "superset"/higher complexity combination here. or is that it?
|
https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=21938&view=results |
vinothchandar
approved these changes
Jan 17, 2024
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
…ests (#10492) * reduce combos of tests * build success --------- Co-authored-by: Jonathan Vexler <=>
yihua
pushed a commit
that referenced
this pull request
May 3, 2024
…ests (#10492) * reduce combos of tests * build success --------- Co-authored-by: Jonathan Vexler <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
testBootstrapRead and TestHoodieDeltaStreamerSchemaEvolutionQuick have many combinations of params. While it is good to test everything, there are lots of code paths that have extensive duplicate testing. Reduce the number of tests while still maintaining code coverage
Impact
faster CI
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist