[HUDI-7305] Fix cast exception for byte/short/float partitioned field #10518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jan 18, 2024
| @@ -274,6 +274,8 @@ object Spark3ParsePartitionUtil extends SparkParsePartitionUtil { | |||
| }.getOrElse { | |||
| Cast(Cast(Literal(value), DateType, Some(zoneId.getId)), dt).eval() | |||
| } | |||
| case BinaryType => value.getBytes() | |||
| case BooleanType => value.toBoolean | |||
| case dt => throw new IllegalArgumentException(s"Unexpected type $dt") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Looks good, can we write a UT for it.
stream2000
force-pushed
the
fix_float_partition
branch
from
1145c5f to
a93b89d
Compare
danny0405
approved these changes
Jan 19, 2024
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix cast exception for byte/short/float partitioned field. Now we may support all type except nested columns.
Impact
Add support for reading byte/short/float partitioned field.
Risk level (write none, low medium or high below)
NONE
Documentation Update
NONE
Contributor's checklist