[HUDI-7367] Add makeQualified APIs #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@linliu-code to review |
| if (!isAbsolute()) { | ||
| throw new IllegalStateException("Only an absolute path can be made qualified"); | ||
| } | ||
| HoodieLocation location = this; |
There was a problem hiding this comment.
found this a bit weird. the assignment from this. is that needed?
| * a new path that includes a path and authority and is fully qualified. | ||
| */ | ||
| @PublicAPIMethod(maturity = ApiMaturityLevel.EVOLVING) | ||
| public HoodieLocation makeQualified(URI defaultUri) { |
There was a problem hiding this comment.
this ought to be a static method? I think we should instead make this a new constructor in HoodieLocation?
vinothchandar
approved these changes
Feb 7, 2024
yihua
added a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR makes the following changes to properly support qualified location:
getUritoHoodieStorage.makeQualifiedtoHoodieLocation.makeQualifiedtoFSUtils.Impact
Properly support qualified location with
HoodieStorageandHoodieLocation. This fixes the original test failures in #10591.Risk level
none
Documentation Update
N/A
Contributor's checklist