[MINOR] Fix zookeeper session expiration bug #10671
Merged
+129
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
MINOR_fix_zookeeper_session_bug
branch
10 times, most recently
from
54a3aa1 to
a5ef9c5
Compare
linliu-code
force-pushed
the
MINOR_fix_zookeeper_session_bug
branch
from
a5ef9c5 to
1ec6943
Compare
yihua
pushed a commit
that referenced
this pull request
Feb 27, 2024
yihua
pushed a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
KafkaTestUtilswas created as a static variable and only initialized at the start of a test class.A test class may contain multiple test methods. If the zookeeper session expires during the middle,
some test methods would fail. And we did see these failures happened in Azure CI.
To solve this problem, we recreated the
KafkaTestUtilsobject for each test method instead.Impact
Fix the session expiration error.
Risk level (write none, low medium or high below)
None.
Contributor's checklist