Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-7406] Rename classes to be readable in storage abstraction #10672

Merged

Conversation

yihua
Copy link
Contributor

@yihua yihua commented Feb 14, 2024

Change Logs

As above, with the following renaming:

  • HoodieLocation -> StoragePath
  • HoodieLocationFilter -> StoragePathFilter
  • HoodieFileStatus -> StoragePathInfo

Impact

Class renaming to improve readability.

Risk level

none

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihua yihua merged commit b99bf70 into apache:master Feb 16, 2024
31 checks passed
yihua added a commit that referenced this pull request Apr 18, 2024
…mmon module (#10591)

This commit makes the changes to replace most `FileSystem`, `Path`, and `FileStatus` usage with `HoodieStorage`, `StoragePath` and `StoragePathInfo` (introduced in #10567, renamed in #10672) in `hudi-common` module, to remove dependency on Hadoop FS abstraction which is not essential to most Hudi core read and write logic.

This commit still keeps using the Hadoop FileSystem-based implementation under the hood.  A follow-up PR will make `HoodieStorage` and I/O implementation pluggable.
yihua added a commit that referenced this pull request May 15, 2024
…mmon module (#10591)

This commit makes the changes to replace most `FileSystem`, `Path`, and `FileStatus` usage with `HoodieStorage`, `StoragePath` and `StoragePathInfo` (introduced in #10567, renamed in #10672) in `hudi-common` module, to remove dependency on Hadoop FS abstraction which is not essential to most Hudi core read and write logic.

This commit still keeps using the Hadoop FileSystem-based implementation under the hood.  A follow-up PR will make `HoodieStorage` and I/O implementation pluggable.
yihua added a commit that referenced this pull request May 15, 2024
…mmon module (#10591)

This commit makes the changes to replace most `FileSystem`, `Path`, and `FileStatus` usage with `HoodieStorage`, `StoragePath` and `StoragePathInfo` (introduced in #10567, renamed in #10672) in `hudi-common` module, to remove dependency on Hadoop FS abstraction which is not essential to most Hudi core read and write logic.

This commit still keeps using the Hadoop FileSystem-based implementation under the hood.  A follow-up PR will make `HoodieStorage` and I/O implementation pluggable.
yihua added a commit that referenced this pull request May 15, 2024
…mmon module (#10591)

This commit makes the changes to replace most `FileSystem`, `Path`, and `FileStatus` usage with `HoodieStorage`, `StoragePath` and `StoragePathInfo` (introduced in #10567, renamed in #10672) in `hudi-common` module, to remove dependency on Hadoop FS abstraction which is not essential to most Hudi core read and write logic.

This commit still keeps using the Hadoop FileSystem-based implementation under the hood.  A follow-up PR will make `HoodieStorage` and I/O implementation pluggable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants