[HUDI-7410] Use SeekableDataInputStream as the input of native HFile reader #10673
+71
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvex
reviewed
Feb 15, 2024
| @@ -238,7 +239,7 @@ private static HFileReader createReader(String hFilePath, FileSystem fileSystem) | |||
| LOG.info("Opening HFile for reading :" + hFilePath); | |||
| Path path = new Path(hFilePath); | |||
| long fileSize = fileSystem.getFileStatus(path).getLen(); | |||
| FSDataInputStream stream = fileSystem.open(path); | |||
| SeekableDataInputStream stream = new HadoopSeekableDataInputStream(fileSystem.open(path)); | |||
There was a problem hiding this comment.
Is this going to be HadoopSeekableDataInputStream going forward? Or is hadoop going to be fully removed from here at some point?
There was a problem hiding this comment.
This will be replaced by the new storage API call which returns SeekableDataInputStream directly. Hadoop is going to be fully removed here in the future.
jonvex
approved these changes
Feb 15, 2024
yihua
added a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR makes SeekableDataInputStream as the input of native HFile reader, so that the constructor of the native HFile reader is Hadoop-agnostic.
This is part of the effort to provide Hudi storage abstraction and decouple
hudi-commonfrom hadoop dependencies. For reference, the single big-change PR can be found here: #10360.Impact
The constructor of the native HFile reader is Hadoop-agnostic.
Risk level
none
Documentation Update
N/A
Contributor's checklist