[HUDI-8811] Handle Kafka source configuration-related failures with specific exception handling #12569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsikarnika
changed the title
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java
Outdated
Show resolved
Hide resolved
vamsikarnika
changed the title
added 2 commits
January 3, 2025 23:35
yihua
reviewed
Jan 9, 2025
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestAvroKafkaSource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Y Ethan Guo <[email protected]>
yihua
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Catch KafkaException instances and handle configuration-related errors by wrapping them in a HoodieSourceConfigException. Specifically, handle exceptions such as missing host or port, invalid or unresolved broker addresses, invalid host URLs.
Also in some cases missing required configs. For example when io.confluent.kafka.serializers.KafkaAvroDeserializer(default deserializer) is used as kafka deserializer and schema.registry.url config is missing in the provided configs, KafkaConsumer throws io.confluent.common.config.ConfigException during initialization. We're catching those exceptions and categorising them as HoodieSourceConfigExceptions here.
Impact
Add new exception type for HoodieSourceConfigException to catch issues specific to kafka configs
Risk level (write none, low medium or high below)
low
Documentation Update
NA
Contributor's checklist