[HUDI-8824] MIT should error out for some assignment clause patterns #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8824
branch
3 times, most recently
from
538edc9 to
441d8eb
Compare
yihua
reviewed
Jan 8, 2025
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 8, 2025
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/test/resources/sql-statements.sql
Outdated
Show resolved
Hide resolved
...urce/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoLogOnlyTable.scala
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala
Outdated
Show resolved
Hide resolved
...-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable.scala
Outdated
Show resolved
Hide resolved
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 8, 2025
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Outdated
Show resolved
Hide resolved
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8824
branch
3 times, most recently
from
3f5a535 to
631494d
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8824
branch
from
631494d to
ffad811
Compare
yihua
reviewed
Jan 14, 2025
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 14, 2025
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...udi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala
Show resolved
Hide resolved
yihua
reviewed
Jan 14, 2025
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Show resolved
Hide resolved
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Outdated
Show resolved
Hide resolved
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Outdated
Show resolved
Hide resolved
...datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/dml/TestMergeIntoTable2.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
For insert and update clause of MIT, in some cases if we didn't set the primary key/precombine field value explicitly, MIT errors out in the query analyze phase.
Also some changes that make sure the precombine key value data type is the same over source and target table (an irrelevant test maintenance)
Impact
Better user facing error message and guard against cases we don't support.
Risk level (write none, low medium or high below)
none
Documentation Update
We track MIT doc update all in https://issues.apache.org/jira/browse/HUDI-8527
Contributor's checklist