[HUDI-8823] Ban update from updating primary key and partition key #12587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
from
ed91af8 to
b247739
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
from
b247739 to
0c68d4f
Compare
yihua
reviewed
Jan 8, 2025
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
Show resolved
Hide resolved
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
...e/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/UpdateHoodieTableCommand.scala
Outdated
Show resolved
Hide resolved
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
4 times, most recently
from
e2db61c to
3cdd40d
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
from
3cdd40d to
93feda8
Compare
yihua
reviewed
Jan 14, 2025
Comment on lines
404
to
410
| assert(e1.getMessage.contains("Detected disallowed assignment clause in UPDATE statement for record key field `id`")) | ||
|
|
||
| // Try to update partition column (should fail) | ||
| val e2 = intercept[AnalysisException] { | ||
| spark.sql(s"update $tableName set pt = '2022' where id = 1") | ||
| } | ||
| assert(e2.getMessage.contains("Detected update query with disallowed assignment clause for partition field `pt`")) | ||
| assert(e2.getMessage.contains("Detected disallowed assignment clause in UPDATE statement for partition field `pt`")) |
There was a problem hiding this comment.
Add . Please remove the assignment clause to avoid the error.?
yihua
approved these changes
Jan 14, 2025
| spark.sql(s"update $tableName set id = 2 where id = 1") | ||
| } | ||
| assert(e1.getMessage.contains(s"Detected disallowed assignment clause in UPDATE statement for record key field `id`" + | ||
| s" for table `spark_catalog.default.$tableName`. Please remove the assignment clause to avoid the error.")) |
There was a problem hiding this comment.
Does Spark add spark_catalog. as the table name prefix? Could that be remove to avoid confusing users?
There was a problem hiding this comment.
I think it is good to stick to full qualifiers than just table name, since this causes 0 ambiguity. If given this fact we still think table name alone is better, I can fix
There was a problem hiding this comment.
Also for other loggings and user messages of SQL, we are consistently sticking to this format. The spark_catalog. is the catalog name.
There was a problem hiding this comment.
Sg. Could you check the test failures on Spark 3.4?
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
from
4925fc8 to
1eacea9
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8823
branch
from
f795ba1 to
39d7308
Compare
cshuo
pushed a commit
to cshuo/hudi
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
update will error out when it tries to change partition column /primary key column value.
Impact
guard update against unsupported use cases.
Risk level (write none, low medium or high below)
none
Documentation Update
Maybe we should update the update query doc on this behavior.
Contributor's checklist