Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8766] Enabling cols stats by default with writer #12596

Conversation

nsivabalan
Copy link
Contributor

Change Logs

  • Enabling cols stats by default on writer in SPARK engine
  • Added support for timestamp, Date, LocalDate, Decimal.

Few features/tests where col stats is disabled:

Impact

Enabling col stats by default on the writer will improve query performance.

Risk level (write none, low medium or high below)

medium

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@nsivabalan nsivabalan requested a review from codope January 8, 2025 01:50
@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Jan 8, 2025
Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Comments from #12511 for colstats are already addressed, and there will be a separate PR for partition stats.

@@ -214,7 +214,7 @@ stages:
displayName: Top 100 long-running testcases
- job: UT_FT_3
displayName: UT spark-datasource Java Tests & DDL
timeoutInMinutes: '90'
timeoutInMinutes: '120'
Copy link
Member

@codope codope Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure that colstats support for test table, and lowering the test timeout is tracked in JIRA.

@codope codope force-pushed the enablePartitionStatsByDefault2_onlyColStats_sqa_rebased branch from 2710a96 to b900faf Compare January 10, 2025 08:07
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit 7c1431d into apache:master Jan 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L PR with lines of changes in (300, 1000]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants