-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-8766] Enabling cols stats by default with writer #12596
[HUDI-8766] Enabling cols stats by default with writer #12596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Comments from #12511 for colstats are already addressed, and there will be a separate PR for partition stats.
hudi-common/src/test/java/org/apache/hudi/avro/TestHoodieAvroUtils.java
Outdated
Show resolved
Hide resolved
@@ -214,7 +214,7 @@ stages: | |||
displayName: Top 100 long-running testcases | |||
- job: UT_FT_3 | |||
displayName: UT spark-datasource Java Tests & DDL | |||
timeoutInMinutes: '90' | |||
timeoutInMinutes: '120' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make sure that colstats support for test table, and lowering the test timeout is tracked in JIRA.
2710a96
to
b900faf
Compare
Change Logs
Few features/tests where col stats is disabled:
Impact
Enabling col stats by default on the writer will improve query performance.
Risk level (write none, low medium or high below)
medium
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist