-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-8664] Fix TestSparkSqlCoreFlow to be based on completion time #12602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8664
branch
from
January 8, 2025 21:07
c9c705c
to
f77c625
Compare
yihua
reviewed
Jan 9, 2025
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 9, 2025
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDataSourceHelpers.java
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 9, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 9, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 9, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Jan 9, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8664
branch
3 times, most recently
from
January 9, 2025 02:09
3192ada
to
4d43cbd
Compare
Davis-Zhang-Onehouse
force-pushed
the
HUDI-8664
branch
from
January 9, 2025 02:13
4d43cbd
to
efc1e23
Compare
yihua
reviewed
Jan 14, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Show resolved
Hide resolved
…i/functional/TestSparkSqlCoreFlow.scala
yihua
approved these changes
Jan 14, 2025
...k-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSqlCoreFlow.scala
Outdated
Show resolved
Hide resolved
…i/functional/TestSparkSqlCoreFlow.scala
yihua
changed the title
[HUDI-8664] adapt TestSparkSqlCoreFlow for hudi stream API
[HUDI-8664] Fix TestSparkSqlCoreFlow to be based on completion time
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix broken test as we changed hudi_table_change to spark streaming.
Impact
TestSparkSqlCoreFlow all green now
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist