ci(golangci-lint) :Add golangci linter #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zeroshade It seems the Golang CI lint does work 😄 . https://github.com/apache/iceberg-go/actions/runs/13532254394/job/37817030681?pr=315 I will go ahead and fix the highlighted issues |
dttung2905
force-pushed
the
add-golangci-linter
branch
from
cd8b923 to
5b967f0
Compare
|
@dttung2905 Looks good, once you resolve the conflicts i'm happy to merge this. |
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
Signed-off-by: dttung2905 <[email protected]>
dttung2905
force-pushed
the
add-golangci-linter
branch
from
6b5faa5 to
5396f4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the feedback #306 (comment), I'm adding golangci-lint in GIthub Action CI. There are many different linters but I'm just adding the most basic one. We can definitely add more if needed
I have not run golangci-lint with
--fixargument. I plan to get it flagged out in the PR as a form of testing. Let me know if we want to commit the changes after fixing