Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn ObjectStoreLocationProvider off by default #1721

Closed
3 tasks
kevinjqliu opened this issue Feb 25, 2025 · 0 comments · Fixed by #1722
Closed
3 tasks

turn ObjectStoreLocationProvider off by default #1721

kevinjqliu opened this issue Feb 25, 2025 · 0 comments · Fixed by #1722

Comments

@kevinjqliu
Copy link
Contributor

Apache Iceberg version

main (development)

Please describe the bug 🐞

As part of implementing LocationProvider, ObjectStoreLocationProvider was enabled by default.

This will create a change in default behavioral for location of data files. We want to turn it off by default so SimpleLocationProvider is used

iceberg-python/pyiceberg/table/locations.py

Lines 199 to 200 in 71129ee

if property_as_bool(table_properties, TableProperties.OBJECT_STORE_ENABLED, TableProperties.OBJECT_STORE_ENABLED_DEFAULT):
return ObjectStoreLocationProvider(table_location, table_properties)

iceberg-python/pyiceberg/table/__init__.py

Line 205 in 71129ee

OBJECT_STORE_ENABLED_DEFAULT = True

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@kevinjqliu kevinjqliu mentioned this issue Feb 25, 2025
Merged
@geruh geruh mentioned this issue Feb 25, 2025
Merged
kevinjqliu pushed a commit that referenced this issue Feb 26, 2025
@geruh
Update docs to reflect default location provider (#1724)
acb3c47 
Update the docs to reflect the simple location provider as the default
location provider.

related to #1721, and #1722.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn ObjectStoreLocationProvider off by default kevinjqliu/iceberg-python
1 participant
@kevinjqliu