test: Remove binary manifest list avro file #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Dec 13, 2023
liurenjie1024
force-pushed
the
renjie/issue-70
branch
from
cfe14d9 to
1460a10
Compare
Fokko
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
One small nit, great to get rid of those binaries! Thanks @liurenjie1024
Fokko
reviewed
Dec 14, 2023
|
Thanks again @liurenjie1024 for working on this. @Xuanwo and @ZENOTME thanks for the review 👍 |
shaeqahmed
pushed a commit
to matanolabs/iceberg-rust
that referenced
this pull request
Dec 9, 2024
* Remove binary manifest list avro file * Remove binary manifest * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #70
We generate manifest list avro file on the fly.